In #2666392: Unable to revert third party settings via config import it was suggested that we deprecate the fallback to schema for discovering a config entities properties to export. And enforce config entities to declare their properties in their annotation config_export property.
Add a deprecation and CR so people can prepare for Drupal 9.
None
None - a code path will be deprecate in Drupal 8 and removed in Drupal 9 - so the API change is in Drupal 9.
None
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 2949021-configexport-11-interdiff.txt | 2.2 KB | tim.plunkett |
| #11 | 2949021-configexport-11.patch | 7.87 KB | tim.plunkett |
| #7 | 2949021-configexport-7-interdiff.txt | 3.58 KB | tim.plunkett |
| #7 | 2949021-configexport-7.patch | 7.87 KB | tim.plunkett |
| #5 | 2949021-config_export-5.patch | 6.59 KB | tim.plunkett |
Comments
Comment #3
wim leersComment #4
wim leers#3015759-24: `?filter[drupal_internal__id]=ID` does not work: drupal_internal__id should not be converted to uuid when filtering was adversely affected by this not yet having happened: it now needs to have an instance in hand to determine what the schema is of a config entity. So not doing this adversely affects API-First Drupal. Hence increasing priority.
Comment #5
tim.plunkettNot sure why this was postponed, but here's a patch.
Comment #7
tim.plunkettMade the trigger_error more helpful and fixed two more config entities.
Comment #8
wim leersThanks! This looks great. It adds a deprecation error, has an explicit test for that deprecation error, and fixes all config entity types in core to ensure they don't trigger this deprecation error. Looks ready 👍
Comment #9
wim leersUpdated the existing change record https://www.drupal.org/node/2949023 to link to this issue.
Comment #10
tim.plunkettExcept the deprecation error has to point to the CR
Comment #11
tim.plunkettComment #12
alexpottCrediting @Wim Leers for digging out the CR
Committed 2bbbaa3 and pushed to 8.7.x. Thanks!
Comment #14
wim leers#10: d'oh, of course!
#12: 🙏😊