Found several coding standard errors:
1. A typo in the RestMenuItemsCacheableDependency filename and class name (is RestMenuItemsCachableDepenency).
2. Argument type not defined or wrong
3. minor comment and indentation issues.

CommentFileSizeAuthor
#2 2948693.patch6.94 KBziomizar

Comments

ziomizar created an issue. See original summary.

ziomizar’s picture

ziomizar commented
Issue summary: View changes
StatusFileSize
new 2948693.patch6.94 KB
ziomizar’s picture

ziomizar commented
Status: Active » Needs review

  • fabianderijk committed 1a9e469 on 8.x-2.x 
    Issue #2946392 by ziomizar: Setup basic key in the output when installed...
fabianderijk’s picture

fabianderijk
him/his
Primary language Dutch
Location Alphen aan den Rijn
commented
Status: Needs review » Fixed

Your patch has been partially applied. The wrong argument type was not wrong, so that has been reverted to original.

Available in version 8.x-2.1.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.