The libraries module uses some deprecated code which has been fixed in this patch: #2779591: Version Callback functions that pass parameters by reference not permitted in PHP 7

Let's include this patch.

CommentFileSizeAuthor
#5 panopoly_core-libraries-php-7-compat-2948452-5.patch411 bytescboyden
#3 panopoly-core-libraries-php-7-compat-2948452.patch495 bytesbkosborne

Comments

bkosborne created an issue. See original summary.

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Issue summary: View changes
bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Status: Active » Needs review
StatusFileSize
new panopoly-core-libraries-php-7-compat-2948452.patch495 bytes
cboyden’s picture

cboyden commented
Title: Include patch to libraries module that resolves deprecation warning for PHP 7 » Update libraries module to resolve deprecation warning for PHP 7
Issue tags: +PHP 7.2

Libraries has released a new version 2.5 that fixes the issue.

cboyden’s picture

cboyden commented
StatusFileSize
new panopoly_core-libraries-php-7-compat-2948452-5.patch411 bytes

Updated patch to build libraries version 2.5.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Here's a test build on Travis:

https://travis-ci.org/panopoly/panopoly/builds/445343837

  • dsnopek committed 0f888ab on 7.x-1.x 
    Update Panopoly Core for Issue #2948452 by bkosborne, cboyden: Update...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Tests passed, manual testing seemed fine, reviewed the changes. Committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.