namespaces issue, SimpleSAML_Auth_Simple changes to Simple

Thanks @oknate! Looks good :)

These changes fixes the issues related to the update from the simplesamlphp library 1.14.17 to 1.15.3. However, these are a few coding standard violations that should be fixed before this is committed:

1. +++ b/src/Service/SimplesamlphpAuthManager.php
   @@ -46,17 +46,17 @@ class SimplesamlphpAuthManager {
   +   * @param Simple $instance
   

   Data types in @param tags need to be fully namespaced

2. +++ b/tests/simplesamlphp_auth_test/src/SimplesamlphpAuthTestManager.php
   --- a/tests/src/Unit/Service/SimplesamlphpAuthManagerTest.php
   +++ b/tests/src/Unit/Service/SimplesamlphpAuthManagerTest.php
   
   +++ b/tests/src/Unit/Service/SimplesamlphpAuthManagerTest.php
   @@ -42,7 +42,7 @@ class SimplesamlphpAuthManagerTest extends UnitTestCase {
   +   * @var \Simple|\PHPUnit_Framework_MockObject_MockObject
   

   Undefined class Simple

3. There are a few stray occurrences of the old classname in the repository:
   - Drupal\simplesamlphp_auth\Service::__construct()
   - Drupal\simplesamlphp_auth_test\SimplesamlphpAuthTestManager::__construct()

@oknate Thanks for working on this issue! The changes look great, only #7.1 still has to be addressed:

+++ b/src/Service/SimplesamlphpAuthManager.php
@@ -3,7 +3,7 @@
+use SimpleSAML\Auth\Simple;

@@ -46,17 +46,17 @@ class SimplesamlphpAuthManager {
+   * @param Simple $instance
+   *    SimpleSAML\Auth\Simple instance.

The @param class reference needs to be fully namespaced: \SimpleSAML\Auth\Simple rather than Simple

Here is the 7.x-3.x patch for 1.15.x compatibility

@oknate I have pushed your code cleanup changes and some additional cleanup. Would you mind re-rolling simplesamlphp_auth-namespace-fix-2947057-11.patch against the latest dev?

@oknate sorry the latest 16 patch failed to apply for me.

The patch applies correctly for me. Sorry for asking, but weren't you trying to apply against RC6 and not the Git checkout? Paths have changed, so that'd be one reason why it'd fail.

Latest one works :D more likely it was pebcak on my side.
Thanks again for your work oknate & all.