Error in composer install

Moving to the proper queue.

That code has been removed as part of the refactor, but I don't see that error in Drupal 8.4.4.

That might be a registry cache issue, so try clearing the cache drush cr.

Please make sure that you have followed the update instructions.

https://www.drupal.org/project/workbench_access/releases/8.x-1.0-alpha7

You need to run drush updb --entity-updates as documented and noted above.

Hello,

Like bas123, I ran all of your suggested updates, and still when installing from composer...

"drupal/workbench": "^1.0",
"drupal/workbench_access": "^1.0-alpha8",
"drupal/workbench_moderation": "^1.2",

I get the error message...
"WorkbenchAccessManager does not have a method getDefaultValue" just like bas123.

I'm installing on Drupal 8.5, and I've tried this with both Drush 8, and 9.

Here is the call stack ...
backtrace ... WorkbenchAccessManager.php ln[176]
[559 - 1 - 1520856764.656] : [drush.php 12] drush_main()
--> [preflight.inc 66] Drush\Boot\BaseBoot->bootstrap_and_dispatch()
--> [BaseBoot.php 67] drush_dispatch()
--> [command.inc 199] drush_command()
--> [command.inc 231] _drush_invoke_hooks()
--> [command.inc 422] drush_default_content_deploy_import()
--> [default_content_deploy.drush.inc 212] Drupal\default_content_deploy\Importer->deployContent()
--> [Importer.php 258] Drupal\default_content_deploy\Importer->loadEntityFromJson()
--> [Importer.php 521] Symfony\Component\Serializer\Serializer->deserialize()
--> [Serializer.php 133] Symfony\Component\Serializer\Serializer->denormalize()
--> [Serializer.php 182] Drupal\hal\Normalizer\ContentEntityNormalizer->denormalize()
--> [ContentEntityNormalizer.php 148] Drupal\Core\Entity\EntityStorageBase->create()
--> [EntityStorageBase.php 184] Drupal\Core\Entity\ContentEntityStorageBase->doCreate()
--> [ContentEntityStorageBase.php 79] Drupal\Core\Entity\ContentEntityStorageBase->initFieldValues()
--> [ContentEntityStorageBase.php 137] Drupal\Core\Field\FieldItemList->applyDefaultValue()
--> [FieldItemList.php 169] Drupal\Core\Field\FieldConfigBase->getDefaultValue()
--> [FieldConfigBase.php 396] call_user_func()
--> Drupal\workbench_access\WorkbenchAccessManager::getDefaultValue()

Just for giggles, I put the function :
/**
* {@inheritdoc}
*/
public static function getDefaultValue() {
// JKH this is what was in this function in prev versions...
return array();
}
into the file WorkbenchAccessManager.php and the problem went away.

Is this problem going to be addressed?

Only if it can reliably be duplicated.

Have you run the entity updates as instructed _after_ installing from composer?

Putting that method back is a reliable shim for the issue.

Here's the output when I did this via composer following the instructions.

No errors.

> domain8: composer require drupal/workbench_access:1.0alpha6
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
  - Installing drupal/workbench_access (1.0.0-alpha6): Downloading (100%)         
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
Writing lock file
Generating autoload files
> Drupal\Core\Composer\Composer::preAutoloadDump
> Drupal\Core\Composer\Composer::ensureHtaccess

> domain8: drush en workbench_access
The following extensions will be enabled: workbench_access
Do you really want to continue? (y/n): y
workbench_access was enabled successfully.                                               [ok]
workbench_access defines the following permissions: administer workbench access, use workbench access, assign workbench access, batch update workbench access, bypass workbench access, view workbench access information

> domain8: composer require drupal/workbench_access:1.0alpha8
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
  - Updating drupal/workbench_access (1.0.0-alpha6 => 1.0.0-alpha8): Downloading (100%)         
> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
Writing lock file
Generating autoload files
> Drupal\Core\Composer\Composer::preAutoloadDump
> Drupal\Core\Composer\Composer::ensureHtaccess

> domain8: drush updb --entity-updates
The following updates are pending:

access_scheme entity type : 
  The Access scheme entity type needs to be installed.
workbench_access module : 
  8002 -   Update to new access-scheme config entity. 
  8003 -   Create the new entity type. 

workbench_access module : 
  Convert role storage.
  Convert configuration into a scheme.
  Convert user storage.

Do you wish to run all pending updates? (y/n): y
Performing workbench_access_update_8002                                                  [ok]
Performing workbench_access_update_8003                                                  [ok]
Post updating workbench_access                                                           [ok]

Error: Call to a member function getConfiguration() on null in Drupal\Core\Config\Entity\ConfigEntityBase->preSave() (line 320 of /Applications/MAMP/htdocs/domain8/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php).
Drush command terminated abnormally due to an unrecoverable error.                       [error]
Cache rebuild complete.                                                                  [ok]
Finished performing updates.                                                             [ok]

That one error is related to #2946766: Error in composer install and only appears when the module has not been configured.

OK, I was able to replicate this.

Thanks for the response.
Yes sir, all updates have been applied.
Composer install.
Then from our post installation script.
drush updb --entity-updates -y

I can reproduce this every single time.
getDefaultValue() WorkbenchAccessManager.php ln[166]
My trace from last run where I had put in the "shim" for this.
/**
* {@inheritdoc}
*/
public static function getDefaultValue() {
// JKH this is what was in this function in prev versions...
return array();
}

Are you saying that you will put this back in?

This is a little bit tricky to handle, because DEV is now unstable with more major changes coming, including the removal of the field that is causing the error.

The attached patch will make this specific error go away.

My apologies for the confusion, we have tests for the upgrade path, but they don't cover this instance.

And a patch which makes existing tests fail.

And combined for a passing test.

Thank you very much for the quick response!
We have a week or more before we deploy our solution, so we can wait until this patch is in a stable release.
In the meantime the "shim" will allow us to continue development.
Thanks again...

bas123, you don't need to go through any of those gyrations to apply the temporary fix.

If you have alpha8 installed, all you have to do is open the PHP file ...
web/modules/contrib/workbench_access/src/WorkbenchAccessManager.php
Scroll to the bottom of the file.
Insert this function into the class.

/**
* {@inheritdoc}
*/
public static function getDefaultValue() {
// JKH this is what was in this function in prev versions...
return array();
}

I think that the author is going to add this function back into his next alpha release.
Until it is released, this shim will work.

The instructions from @JKHenderson are correct. You can either patch workbench_access/src/WorkbenchAccessManager.php manually, or download and apply https://www.drupal.org/files/issues/2018-03-12/2946766-wa-field-test-pas... patch -p1 < 2946766-wa-field-test-passl.patch from the root directory of the workbench_access folder.

There is no need to downgrade to alpha6 with this patch.

If you choose to uninstall the module, it will have no effect on the rest of Workbench.

There probably won't be another alpha release. I spent yesterday testing the upgrade path and creating https://github.com/agentrickard/workbench_access/pull/110. The problem is that the current DEV branch contains major changes that mean that we cannot make another release without a major upgrade.

The error means that you are not working with a Git checkout of the code base. So you cannot apply the patch with git apply

Use the more generic command that I pasted above:

patch -p1 < 2946766-wa-field-test-passl.patch 

Here are the exact steps that I took to install the patch...
Open terminal window.
Change to the directory where you have workbench_access installed, in my case this was...
web/modules/contrib/workbench_access
Copy or download the file 2946766-wa-field-test-passl.patch to this directory.
Run the command...
patch -p1 < 2946766-wa-field-test-passl.patch

You can also just open the file...
WorkbenchAccessManager.php
and insert this function into the class WorkbenchAccessManager...

/**
* {@inheritdoc}
*/
public static function getDefaultValue() {
return [];
}

This is exactly what the patch does...
Thank you to the author for his support.

You do not want to be managing the workbench_access code with Git from inside the project git repository. That is a complex operation.

Inserting the code manually is fine. The YouTube instructions you found were not appropriate for this situation.

I agree with the author.
You should look into Composer.
Dependencies in your composer.json file will allow you to download and install contrib modules from their respective sites.
For example in my composer.json file I have the following dependencies that are workbench related...

"drupal/workbench": "^1.0",
"drupal/workbench_access": "^1.0-alpha8",
"drupal/workbench_moderation": "^1.2",

You could put the patch for this in your repo as well (as a temporary solution), and apply the patch as described above as part of your installation script. For example we import content as part of our installation script by executing all of the commands in a file that we call dc.txt.

Sample contents of that file...

drush updb --entity-updates -y
drush cim -y
drush dcdi -y

... your last commands would ...
... change to the directory where you have workbench_access installed.
cd web/modules/contrib/workbench_access
... copy the file 2946766-wa-field-test-passl.patch from where you put it from your git pull.
cp /my/gitplace/2946766-wa-field-test-passl.patch .
... then run the command...
patch -p1 < 2946766-wa-field-test-passl.patch

This is probably outside the scope of this discussion, apologies.

It is asking too much for us to answer your questions about Composer.

See the documentation here for starters -- https://www.drupal.org/docs/develop/using-composer/using-composer-with-d....

This discussion will be irrelevant within a week, however, when beta1 is released and the patch is no longer required.

I don't know enough about Composer to answer that question.

As for the update process, that is all a moot point now, as I am about to tag beta1, which eliminates the need for this patch.

It will require another database update, however.

drush updb --entity-updates or via update.php.

Hello,

The getDefaultValue() method is still missing from WorkbenchAccessManager, 8.x-1.0-beta2.

2946766-wa-field-test-passl.patch does not apply cleanly but adding this to the class fixes the issue. (The test part of the patch is already in the code base.)

public static function getDefaultValue() {
    return [];
  }

Thanks!

Problem still exists. In my case it rises when I try to add a new user in /admin/people/create
So I created the patch to fix this issue for version 2.0.0 also