There is a wrong variable name in /core/modules/node/src/Form/DeleteMultiple.php

CommentFileSizeAuthor
#3 2945369-3-wrong_varaible_name.patch483 bytespasqualle
wrong_varaible_name.patch496 bytespasqualle

Comments

Pasqualle created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, wrong_varaible_name.patch, failed testing. View results

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Needs work » Needs review
StatusFileSize
new 2945369-3-wrong_varaible_name.patch483 bytes
timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs review » Reviewed & tested by the community

Nice find!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: Wrong variable name » Wrong variable name in \Drupal\node\Form\DeleteMultiple
Status: Reviewed & tested by the community » Fixed

This only applies to 8.5.x because entity delete forms have changed in 8.6.x - the new 8.6.x version does not have this bug. As this is a form class it is not API and therefore making a property protected is not an API change.

Committed 82500fa and pushed to 8.5.x. Thanks!

  • alexpott committed 82500fa on 8.5.x 
    Issue #2945369 by Pasqualle: Wrong variable name in \Drupal\node\Form\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.