Problem/Motivation

If someone adds more than a single item to the cart, then the final item added to the cart is what actually gets charged to Square.

Variable name re-use is what is biting us. We have the same variable $square_amount reused throughout the payment gateway.

Proposed resolution

Fix the bug. Super quick. Let's separate out our variable names and name the $square_amount to $square_total_amount when we are dealing with the square total amount.

Remaining tasks

Review patch.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2944857.patch2.32 KBheddn

Comments

heddn created an issue. See original summary.

heddn’s picture

StatusFileSize
new2.32 KB
heddn’s picture

Status: Active » Needs review
heddn’s picture

Issue summary: View changes

  • mglaman committed 667d018 on 8.x-1.x authored by heddn
    Issue #2944857 by heddn: Only final item added to cart is charged to...
mglaman’s picture

Status: Needs review » Fixed

Great catch, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.