Problem/Motivation

CSS files:

  • settings_tray.theme.css
  • settings_tray.toolbar.css

contain css rules like:
background-image: url(../../../misc/icons/bebebe/pencil.svg);
However, they are located at level 4, so the correct path will be
background-image: url(../../../../misc/icons/bebebe/pencil.svg);

The result is a 404 error in resourses.

Proposed resolution

Fix all cases with incorrect path in these files.

Remaining tasks

  1. Find someone to help.
  2. Make a fix.
  3. Make a review.
  4. Make a commit.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 fix_path_for_pancel_settings_tray.patch2.84 KBvitaliyb98

Comments

Anonymous’s picture

Anonymous (not verified) commented

vaplas created an issue. See original summary.

vitaliyb98’s picture

vitaliyb98 commented
StatusFileSize
new fix_path_for_pancel_settings_tray.patch2.84 KB

Fixing path for this image. Please review my patch.

vitaliyb98’s picture

vitaliyb98 commented
Status: Needs work » Needs review
Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

@VitaliyB98, thanks for quick and good fix! '404 (Not Found)' error go on after #2 patch! Also no other incorrect paths were found.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Looks like this was a copy error when copying the CSS to stable from the module. Nice find.

Committed acb5c9e and pushed to 8.5.x. Thanks!
Committed 5f319c0 and pushed to 8.6.x. Thanks!

  • alexpott committed 5f319c0 on 8.6.x 
    Issue #2943445 by VitaliyB98: Incorrect path to icons in stable/...

  • alexpott committed acb5c9e on 8.5.x 
    Issue #2943445 by VitaliyB98: Incorrect path to icons in stable/...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.