Problem/Motivation

As you can see from the namespace, Drupal\simpletest\Tests\KernelTestBaseTest isn't where it should be, and probably isn't being run.

It should be in /core/tests/Drupal/KernelTests/. There's a little problem, however, that another KernelTestBaseTest class exists there.

Proposed resolution

Move Drupal\simpletest\Tests\KernelTestBaseTest to Drupal\KernelTests, renaming the test class.

Or...

Merge the two classes.

Figure out which.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 2942633.patch38.9 KBbhanuprakashnani
#8 2942633-8.patch23.7 KBbhanuprakashnani
#5 2942633-5.patch15.3 KBbhanuprakashnani
#3 2942633-3.patch15.29 KBbhanuprakashnani

Comments

Mile23 created an issue. See original summary.

bhanuprakashnani’s picture

bhanuprakashnani commented
Assigned: Unassigned » bhanuprakashnani
bhanuprakashnani’s picture

bhanuprakashnani commented
Status: Active » Needs review
StatusFileSize
new 2942633-3.patch15.29 KB

@Mile23

Merged the two KernelTestBaseTest.php and the patch applies cleanly in my files. Please review.

Status: Needs review » Needs work

The last submitted patch, 3: 2942633-3.patch, failed testing. View results

bhanuprakashnani’s picture

bhanuprakashnani commented
Status: Needs work » Needs review
StatusFileSize
new 2942633-5.patch15.3 KB

Status: Needs review » Needs work

The last submitted patch, 5: 2942633-5.patch, failed testing. View results

bhanuprakashnani’s picture

bhanuprakashnani commented
Status: Needs work » Needs review
bhanuprakashnani’s picture

bhanuprakashnani commented
StatusFileSize
new 2942633-8.patch23.7 KB

Status: Needs review » Needs work

The last submitted patch, 8: 2942633-8.patch, failed testing. View results

bhanuprakashnani’s picture

bhanuprakashnani commented
Status: Needs work » Needs review
bhanuprakashnani’s picture

bhanuprakashnani commented
StatusFileSize
new 2942633.patch38.9 KB

Status: Needs review » Needs work

The last submitted patch, 11: 2942633.patch, failed testing. View results

bhanuprakashnani’s picture

bhanuprakashnani commented
Status: Needs work » Needs review

I have an idea to change the class name in KernelTestbaseTest.php in the SimpleTest folder and then merge it into KernelTestBaseTest.php in the KernelTests folder. If this is right then I'll proceed. Please guide me.

bhanuprakashnani’s picture

bhanuprakashnani commented
Status: Needs review » Needs work

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs work » Postponed (maintainer needs more info)

I'm assuming this is about \Drupal\simpletest\Tests\KernelTestBaseTest.

Since that is a test for the old, deprecated \Drupal\simpletest\KernelTestBase, shouldn't we just leave it where it is, so it can be removed along with the old KernelTestBase?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

Yeah this is testing the old Simpltetest version of kernel testing so there's nothing to do.