Rewrite FormsStepsTest static paths with route path.

Example:
L111:
$this->drupalGet('admin/structure/display-modes/form/add/node');

Must be changed to:
$this->drupalGet(Url::fromRoute('entity.forms_steps.add_form'));

CommentFileSizeAuthor
#8 testfromroutes-2941782-7.patch6 KBHakimR
#6 testfromroutes-2941782-6.patch3.19 KBnicoloye
#4 2941782-4.patch1.07 KBdinesh18

Comments

HakimR created an issue. See original summary.

HakimR’s picture

HakimR commented
Status: Active » Needs work
nicoloye’s picture

nicoloye commented
Assigned: christophe.klein » nicoloye
dinesh18’s picture

dinesh18 commented
Status: Needs work » Needs review
StatusFileSize
new 2941782-4.patch1.07 KB

Here is the initial patch.

Status: Needs review » Needs work

The last submitted patch, 4: 2941782-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

nicoloye’s picture

nicoloye commented
Status: Needs work » Needs review
StatusFileSize
new testfromroutes-2941782-6.patch3.19 KB

Here is a complete version of the intended modifications.

nicoloye’s picture

nicoloye commented
Status: Needs review » Needs work

Our recent work to remove dependencies on form_mode_manager made this patch obsolete.

HakimR’s picture

HakimR commented
Assigned: nicoloye » HakimR
StatusFileSize
new testfromroutes-2941782-7.patch6 KB

Version without conflict fitting the last devs and new routes fixed as well.

  • nicoloye committed 587e863 on 8.x-1.x authored by HakimR 
    Issue #2941782 by HakimR, nicoloye, Dinesh18: Replace static path with...
nicoloye’s picture

nicoloye commented
Assigned: HakimR » Unassigned
Status: Needs work » Fixed

Thanks !
Merged !

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.