CommentFileSizeAuthor
#6 2941383-6.patch2.69 KBmarkdorison
#2 2941383-2.patch2.69 KBmarkdorison

Comments

markdorison created an issue. See original summary.

markdorison’s picture

markdorison
he/him
commented
Status: Active » Needs review
StatusFileSize
new 2941383-2.patch2.69 KB
matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Status: Needs review » Needs work

Hello,

Thanks for your time!
There is one minor issue after review.

'#description' => $this->t('Add tag by mail key. See @link for details.', [
        '@link' => Link::fromTextAndUrl($this->t('Mailgun\'s tagging documentation'),

We should avoid backslash escaping in translatable strings.

matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented

Oops, added the message from this issue: #2941381: Update config page title/description for consistency
It still needs work.

markdorison’s picture

markdorison
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new 2941383-6.patch2.69 KB

Issue from #3 updated.

matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Status: Needs review » Fixed

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.