This may need more research, but based on discussion in #2931883: Unneeded always_populate_raw_post_data requirements check while on CLI the REST module's always_populate_raw_post_data requirement check is possibly not necessary.

And at least, it appears to enforce a solution to the problem that may not be the best one (see #2931883-11: Unneeded always_populate_raw_post_data requirements check while on CLI).

CommentFileSizeAuthor
#2 2940417-2.patch1.19 KBDavid_Rothstein

Comments

David_Rothstein created an issue. See original summary.

David_Rothstein’s picture

David_Rothstein commented
Status: Active » Needs review
StatusFileSize
new 2940417-2.patch1.19 KB

Here is a patch for discussion purposes if nothing else.

David_Rothstein’s picture

David_Rothstein commented
Issue summary: View changes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes
Related issues: +#2456025: PHP warnings in PHP 5.6 because of always_populate_raw_post_data ini setting, +#2931883: Unneeded always_populate_raw_post_data requirements check while on CLI
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

I'd be tempted to stick to what we have for now and then remove this once Drupal 8 requires PHP 7, i.e. in Drupal 8.7 (see https://groups.drupal.org/node/518200). Minimize change for what clearly is a buggy edge case.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Version: 8.6.x-dev » 9.x-dev

Based on #2485847: Automatically populating $HTTP_RAW_POST_DATA is deprecated and will be removed in a future version, which #2456025-30: PHP warnings in PHP 5.6 because of always_populate_raw_post_data ini setting pointed to, this is necessary not just for REST but even just using install.php, i.e. necessary to be able to install D8 on certain hosting environments.

Therefore moving this to D9.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Closed (duplicate)
Related issues: +#2893804: Remove rest.module BC layers

Incorporated the removal of rest_requirements() in #2893804 — see #2893804-24: Remove rest.module BC layers.

Version: 9.x-dev » 9.0.x-dev

The 9.0.x branch will open for development soon, and the placeholder 9.x branch should no longer be used. Only issues that require a new major version should be filed against 9.0.x (for example, removing deprecated code or updating dependency major versions). New developments and disruptive changes that are allowed in a minor version should be filed against 8.9.x, and significant new features will be moved to 9.1.x at committer discretion. For more information see the Allowed changes during the Drupal 8 and 9 release cycles and the Drupal 9.0.0 release plan.