Problem/Motivation

Since it is now generally known as 'media item' there are still some places in core where the term 'media entity' is used.

Proposed resolution

Replace all instances of 'media entity' to 'media item'. Only references to the old 'Media Entity' contrib module should be untouched.

CommentFileSizeAuthor
#7 interdiff-2940169-5-7.txt1.91 KBjefuri
#7 remove-occurences-media-entity-2940169-7.patch9.01 KBjefuri
#5 interdiff.txt805 bytesnitebreed
#5 remove-occurences-media-entity-2940169-5.patch9.01 KBnitebreed
#2 remove-occurences-media-entity-2940169-2.patch10.07 KBnitebreed

Comments

Nitebreed created an issue. See original summary.

nitebreed’s picture

nitebreed
Primary language Dutch
commented
Status: Active » Needs review
StatusFileSize
new remove-occurences-media-entity-2940169-2.patch10.07 KB

See attached patch

jefuri’s picture

jefuri commented
Status: Needs review » Reviewed & tested by the community

Could not find any other "media entity" naming to be done, so this looks good & review is OK. Assuming the automated test agree with me, I am setting this to RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: remove-occurences-media-entity-2940169-2.patch, failed testing. View results

nitebreed’s picture

nitebreed
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new remove-occurences-media-entity-2940169-5.patch9.01 KB
new interdiff.txt805 bytes

Patch was failing due to the fact that the MediaResourceTestBase is checking on the generic update / delete entity string. So we can't change this unfortunately. See updated patch.

seanb’s picture

seanb
Primary language Dutch
Location Netherlands
commented
Status: Needs review » Needs work 
  1. +++ b/core/modules/media/src/MediaAccessControlHandler.php
@@ -8,7 +8,7 @@
+ * Defines an access control handler for the media item.

    Let's change this to "Defines an access control handler for media items." 

  2. +++ b/core/modules/media/tests/src/Functional/MediaCacheTagsTest.php
@@ -7,7 +7,7 @@
+ * Tests the media item's cache tags.

    "item's" should be "items" 

  3. +++ b/core/modules/media/tests/src/Functional/MediaFunctionalTestTrait.php
@@ -13,7 +13,7 @@
+    // Media item permissions.

    Let's change this to "Media module permissions" 

  4. +++ b/core/modules/media/tests/src/Kernel/MediaLinkRelationsTest.php
@@ -5,7 +5,7 @@
+ * Tests link relationships for the media item.

    Let's change this to "Tests link relationships for media items."

jefuri’s picture

jefuri commented
Status: Needs work » Needs review
StatusFileSize
new remove-occurences-media-entity-2940169-7.patch9.01 KB
new interdiff-2940169-5-7.txt1.91 KB

Processed all comment from @seanB.

nitebreed’s picture

nitebreed
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

Looks good!

catch’s picture

catch
he/him
Primary language English
commented
Version: 8.6.x-dev » 8.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.6.x and cherry-picked to 8.5.x. Thanks!

  • catch committed da40533 on 8.6.x 
    Issue #2940169 by Nitebreed, jefuri, seanB: Remove all occurences of '...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.