Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
The return statement for getLegacyDrupalVersion() returns a string but the documentation states it is either an int|false.
The return statement:
return $version_string ? substr($version_string, 0, 1) : FALSE;
An admittedly brief and this value seems to be used as a string both in core and migrate_upgrade. Maybe just change the documentation?
Proposed resolution
Remaining tasks
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | drupal_core-returndocs-2940108-8-D8.patch | 855 bytes | ioana apetri |
| #5 | drupal_core-returndocs-2940108-D8.patch | 856 bytes | ioana apetri |
Comments
Comment #2
quietone CreditAttribution: quietone at Acro Commerce commentedFix errors in IS.
Comment #3
quietone CreditAttribution: quietone at Acro Commerce commentedNot paying attention to the details today. This is active.
Comment #4
ioana apetri CreditAttribution: ioana apetri at OPTASY commentedComment #5
ioana apetri CreditAttribution: ioana apetri at OPTASY commentedIf it is admitted, here is the patch of returning string documentation. Please review it.
Thanks:)
Comment #6
maxocub CreditAttribution: maxocub as a volunteer commentedSorry for kicking this back for such a small nit, but it should be 'A string' and not 'An string'.
Comment #7
ioana apetri CreditAttribution: ioana apetri at OPTASY commentedI'll do it right now.
Comment #8
ioana apetri CreditAttribution: ioana apetri at OPTASY commentedHere is the update. Thanks for the review.
Comment #9
maxocub CreditAttribution: maxocub as a volunteer commentedMuch better, thank you! RTBC, as I'm confident the tests will still be green.
Comment #12
catchCommitted/pushed to 8.6.x and cherry-picked to 8.5.x, thanks!