The comment describing what ContentEntityBase::isTranslatable() does is the following one.

  // Check that the bundle is translatable, the entity has a language defined
  // and if we have more than one language on the site.

In American English, Oxford comma should be used and that is not necessary. I would also change from we have more than one language to the site has more than one language.

  // Check the bundle is translatable, the entity has a language defined, and
  // the site has more than one language.
CommentFileSizeAuthor
#5 2940051-5-D8.patch885 bytesmohit1604
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kiamlaluno created an issue. See original summary.

apaderno’s picture

Issue summary: View changes
apaderno’s picture

Issue summary: View changes
mohit1604’s picture

Assigned: Unassigned » mohit1604
mohit1604’s picture

Status: Active » Needs review
FileSize
885 bytes

@kiamlaluno Thanks for the issue. Please review the patch :)

mohit1604’s picture

Assigned: mohit1604 » Unassigned
chiranjeeb2410’s picture

Status: Needs review » Reviewed & tested by the community

Patch applies cleanly and improvements as suggested by @kiamluno in description.
RTBC for me.

  • catch committed b5880ee on 8.6.x
    Issue #2940051 by Mohit Malik, kiamlaluno: Fix the punctuation in the...
catch’s picture

Version: 8.6.x-dev » 8.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.6.x and cherry-picked to 8.5.x. Thanks!

  • catch committed 3320b3b on 8.5.x
    Issue #2940051 by Mohit Malik, kiamlaluno: Fix the punctuation in the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.