Add Discount (promotion) as line item

Updated patch.

Hmm, those strings that failed are the same.

Not sure, where this is failing...doesn't fail locally.

Lets try this again.

Thanks for the review. Been tied up but here is an updated patch. Sorry, I never noticed comment #3.

#3-1.

Is 64 chars the limit in QB?

No, I think item names are actually limited to 31 characters but I was actually think about writing a patch that split parent ref and item ref from a string if that is enabled in the admin config so lets just remove this restiction for now.

#3-2.

Why do we need to have a single discount for all line items?

We don't but it would be hard to map discounts to different discount items in QB on the fly. I had this required that way because if this is empty or doesn't match a current item in Quickbooks the import will fail. Maybe better to set the field as required? This would also be necessary for shipping as well. If the name for the shipping doesn't match an item in Quickbooks the import will fail.

#13-1. - Answered in #3-2

#13-2. Update in patch. Let me know if you would like me to do it differently.

Fixed coding standards problems.

I don't think we can mark this required. If it isn't provided, it will simply be empty string.

The only problem is, if left as an empty string, and the XML has an empty value for <ItemRef><fullName></fullName></ItemRef> the order will fail export with:

<?xml version="1.0" ?>
<QBXML>
<QBXMLMsgsRs>
<InvoiceAddRs statusCode="3140" statusSeverity="Error" statusMessage="There is an invalid reference to QuickBooks Item &quot;&quot; in the Invoice line. " />
</QBXMLMsgsRs>
</QBXML>

If I do not set <ItemRef><fullName></fullName></ItemRef> if the string is empty so it is not included at all, then I get:

<?xml version="1.0" ?>
<QBXML>
<QBXMLMsgsRs>
<InvoiceAddRs statusCode="3180" statusSeverity="Error" statusMessage="There was an error when saving a Invoice.  QuickBooks error message: You have no items or one or more of your amounts is not associated with an item. Please enter an item." />
</QBXMLMsgsRs>
</QBXML>

The same goes for shipping name.

There's Drupal\commerce_price\Calculator and NumberFormatterFactory that can do all this for you.

Great, I didn't know that. I will take a look and update patch.

So I tried to do this directly in QuickBooks (leave a line item name empty) and it will not let you save the invoice with the same error. Line item names have to match an existing item in QuickBooks. See screenshot.

Lets just make this simpler and use the adjustedUnitPrice for order items. Removed #required for now and we can discuss that in a different issue.

Sorry for the delay on this. I can work on this issue this afternoon.

The 31 char limit is for the full name of the item but the actual Quickbooks identifier uses the full name + the parent name (like you did on the product and product variation export). So if someone had a discount item they wanted to link that was under a parent (Discount Items:General Discount) they could go over the 31 character limit. Parent names do not have a limit.

In the case above we would have to handle splitting the parent name from the item name but that would be easy enough. Again this applies to the shipping name also.

I will open a new issue on this.