This module's README file needs some updates to make it more inline with the Drupal specific template: https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...

I will roll a patch next for your review. Thanks!
Carie

CommentFileSizeAuthor
#5 updates-to-readme-2938638.patch2.29 KBcehfisher
#2 updates-to-read-2938638.patch2.33 KBcehfisher

Comments

cehfisher created an issue. See original summary.

cehfisher’s picture

cehfisher commented
StatusFileSize
new updates-to-read-2938638.patch2.33 KB

OK here is a patch to review for this.

cehfisher’s picture

cehfisher commented
Assigned: cehfisher » Unassigned
Status: Active » Needs review
volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Needs work

Looks like a good improvement in documentation. I tested using simplytest.me and patch applied clean.
Grammar, spelling, and links all look good. Just a couple of nitpicks. Marking as needs work.
Thanks!

  1. +++ b/README.md
@@ -1,32 +1,63 @@
+Drupal 8.2 or lower: Use Twig Extender 8.1.
+Drupal 8.3 or higher: Use Twig Extender 8.2.

    perhaps make into bullet points?? Just a nitpick. 

  2. +++ b/README.md
@@ -35,17 +66,29 @@ Using a exisiting block configuration
+ ¶

    empty space on line 95 

  3. +++ b/README.md
@@ -35,17 +66,29 @@ Using a exisiting block configuration
+ ¶

    empty space on line 95

cehfisher’s picture

cehfisher commented
StatusFileSize
new updates-to-readme-2938638.patch2.29 KB

OK test this one please.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs work » Reviewed & tested by the community

Looks great. Thanks for promptly making those updates!
Marking as RTBC

erik seifert’s picture

erik seifert commented

Thanks.

erik seifert’s picture

erik seifert commented
Version: 8.x-2.1 » 8.x-2.x-dev
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.