PHP 7.2: Warning: count(): Parameter must be an array or an object that implements Countable a FacetapiDependencyFacet->getDefaultSettings()

The patch works, but I would say it is a band-aid fix.
The real problem is that FacetapiDependencyFacet->$defaultSettings is not initialized in the constructor or in its declaration, so it will have the value NULL.

This also means that if ->settingsForm() is called before ->getDefaultSettings(), the initialization in ->getDefaultSettings() will not happen.
This is asking for trouble.

It would be great if the maintainer could illuminate us on the intention behind this.

There's no need for the is_array check. Instead an empty can be used instead which works with lots of different types.

@bkosborne: thanks for the patch, works.

Ran into this issue. Patch works for me too.

Moving to major, PHP 7.1 is "security fixes only", making PHP 7.2 (or higher) the natural choice for current config.

RTBC++

My concern from #4 still applies, I think.

@donquixote you're right, maybe you could provide a patch with the place it should be initialized? It looks like it should be initalized already here:

+++ b/plugins/facetapi/dependency_facet.inc
@@ -136,13 +136,13 @@ class FacetapiDependencyFacet extends FacetapiDependency {
+        'facets' => array(),

Though it is a band-aid fix, I think it's an acceptable one considering all the changes are !count() to empty() which will produce the same value check for NULL/[]/0 as it did before 7.2

I'm still +1 on the current patch but happy to have help from @donquixote to improve on this.

+1

Patch from #5 works well for me too.

#5 worked for me - thanks!

RTBC +1

I am seeing this working fine in our dev environment

RTBC+1

The concern from #4 is not wrong, but I'll give a "+1" to RTBC anyway because I think the patch preserves the original intent, which is all the issue should be obligated to do. It's bad design to have allowed the default settings to be null, but solving that doesn't have to be in the scope of this issue.

***EDIT***
see next comment
***END EDIT***

actually, fixed now see commit.