Error: Undefined index: set

Hi, thanks for the report, and the patch.

Note that you have filed this against 8.x-1.x, but 8.x-2.x is the supported branch. Can you please confirm you are using the supported version and set it in the issue information? Please re-trigger the test as well. You can also, if you are comfortable doing so, create a pull request against https://github.com/dcycle/realistic_dummy_content/tree/8.x-2.x (and reference it here) which will trigger more detailed tests.

Also, I would like to confirm why this happens and add that scenario to my automated tests -- if you know what type of field and data caused this can you please specify it here?

Thanks!

Thanks, I'll set the version of this ticket to 8.x-2.x then. I also started an automated test on Circle CI at https://circleci.com/gh/dcycle/realistic_dummy_content/115 to see if your patch breaks anything.

Are you using this in conjunction with any custom code, or just out of the box?

Thanks for the detailed info and I'm glad you're finding the module useful.

for me it seems that the RDC module should not react for such a case even if some module makes an erroneous or incomplete "DevelGenerate" plugin's implementation

Agreed. However before the patch, I am assuming that value is either an array with the key 'set', or a string. Assigning $value to be the value of $value['set'] might cause some other problems because perphaps $value is already an array, just not having the key 'set'. Then we'd end up with something like ['set' => [some random array], which might break something else.

Instead, how about something like:

if (is_array($value) && !isset($value['set'])) {
drupal_set_message('Not setting an attribute because the data is invalid.', 'error');
return;
}

That way we're not completely breaking but we're not trying to do something with invalid data.

I am trying to extend "DevelGenerate" plugin to generate Drupal Commerce entities, particularly products

I love that idea, and would love to be posted about the progress of that project. If it's open source, you might want to paste the repo URL here.

it does not make more than 15 nodes and gives the server 60 seconds timeout error

I think that is because of #1242352: Don't hard code the 50 node threshold for triggering batch node generation; one way around this is to only use drush, not the GUI, that works for me.

Did you think about separating code bases? Please, though as a proof of concept it looks great but in a practical sense it just makes things overcomplicated

Yeah I tried that just to see if it's possible, plus I don't have the resources to maintain two versions (7 and 8) of realistic dummy content, so it sounded like a good idea... at the time, but I agree it's overly complex. If you have any patches you'd like to submit which do not fit in the "universal code" setup, I'd be glad to tweak them. If you'd like to open an issue discussing separating the two codebases, please do. Please note, though, that although I agree it's overly complex, some complexity is still needed just to make the code unit-testable as well.

This is failing at https://circleci.com/gh/dcycle/realistic_dummy_content/116 with "Illegal string offset 'set' Drupal8.php:247"

I think it's because we need to keep these lines:

-    if (!is_array($value)) {
-      $value = array('set' => $value);

Feel free to modify your pull request at https://github.com/dcycle/realistic_dummy_content/pull/18 directly, that should now trigger tests on Circle CI.

Thanks also for the link to your code, I've often needed to generate content for Drupal Commerce. When it's ready I'll link to it in the Realistic Dummy Content home page.

This is now passing tests so I have included it here.