Need to add a README file per the template shown here: https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...

CommentFileSizeAuthor
#7 2937752-updated-readme-new.patch2.6 KBcehfisher
#3 2937752-updated-readme.patch2.59 KBcehfisher

Comments

cehfisher created an issue. See original summary.

cehfisher’s picture

cehfisher commented
cehfisher’s picture

cehfisher commented
Title: Missing README file » Need to update README format
StatusFileSize
new 2937752-updated-readme.patch2.59 KB
cehfisher’s picture

cehfisher commented
Assigned: cehfisher » Unassigned
Status: Needs work » Needs review
volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Needs work

Patch looks great! Thanks.

One nitpick.

+++ b/README.md
@@ -1,25 +1,60 @@
+ Drupal module. Visit https://www.drupal.org/node/1897420 for further
+ information.

Should be indented to align with "Install" on line 40

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented

Grammar, links, and configs all look good! And patch applied clean with Simple test

cehfisher’s picture

cehfisher commented
StatusFileSize
new 2937752-updated-readme-new.patch2.6 KB

OK updated the spacing on that file. Thanks!

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs work » Reviewed & tested by the community

Indenting has been fixed and it looks great!! Thanks for the prompt work!
Marking as RTBC

ellioseven’s picture

ellioseven commented

That has been committed to the development branch. Thanks for your awesome work guys!

@volkswagenchick I made the commit without your name on it accidentally. I can't seem to rewrite git history either? I'm not sure how I can credit you for you help?

ellioseven’s picture

ellioseven commented
Status: Reviewed & tested by the community » Fixed
volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented

Its all good, cheers!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.