Hi,

Minor issue on .info.yml file.
WARNING | All dependencies must be prefixed with the project name, for example "drupal:"

CommentFileSizeAuthor
#5 coding_standard-2936442-5.patch41.45 KBsivaprasadc
#5 interdiff-2936442-3-5.txt40.71 KBsivaprasadc
#3 update-2936442-3.patch1.03 KBsarguna raj m
#2 code-2936442-2.patch1.03 KBsarguna raj m

Comments

sarguna raj M created an issue. See original summary.

sarguna raj m’s picture

sarguna raj m commented
Assigned: sarguna raj m » Unassigned
Status: Needs work » Needs review
StatusFileSize
new code-2936442-2.patch1.03 KB

Created a patch for the same.
Kindly review. :)

sarguna raj m’s picture

sarguna raj m commented
StatusFileSize
new update-2936442-3.patch1.03 KB

updated the patch.

sivaprasadc’s picture

sivaprasadc commented
Assigned: Unassigned » sivaprasadc
sivaprasadc’s picture

sivaprasadc commented
Assigned: sivaprasadc » Unassigned
Status: Needs review » Needs work
StatusFileSize
new interdiff-2936442-3-5.txt40.71 KB
new coding_standard-2936442-5.patch41.45 KB

@sarguna raj M

Thanks for the patch. Its resolved the dependency issues.

A couple of coding standard issues are still there. Most of them resolved. Please find the interdiff and patch files.

Still Below warnings needs to be resolved.

FILE: ...tribution/bt_article/src/Breadcrumb/ArticleBreadcrumbBuilder.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 38 | WARNING | User::load calls should be avoided in classes, use
    |         | dependency injection instead
 61 | WARNING | \Drupal calls should be avoided in classes, use
    |         | dependency injection instead
----------------------------------------------------------------------
roberto_araya’s picture

roberto_araya commented
Title: All dependencies must be prefixed with the project name » Fix a lot of code standard details
Category: Bug report » Task

Done! and thanks for all code standard recommendations.

roberto_araya’s picture

roberto_araya commented
roberto_araya’s picture

roberto_araya commented
Status: Needs work » Fixed

  • roberto_araya committed 2b12b81 on 8.x-1.x 
    Issue #2936442 by sarguna raj M, Sivaprasad C, roberto_araya: Fix a lot...
roberto_araya’s picture

roberto_araya commented
Status: Fixed » Closed (fixed)