Part of #2924538: [META] Remove all usages of drupal_set_message and drupal_get_messages

CommentFileSizeAuthor
#7 2935779-6-interdiff.txt973 byteskim.pepper
#7 2935779-6.patch8.9 KBkim.pepper
#2 2935254-1.patch8.89 KBkim.pepper

Comments

kim.pepper created an issue. See original summary.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Active » Needs review
StatusFileSize
new 2935254-1.patch8.89 KB

Initial patch split from parent issue.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented

I guess we should wait for #2935153: Rename \Drupal::messenger to \Drupal::legacyMessenger

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

That issue was marked Closed (works as designed)

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

This looks like the changes are done correctly, only a nitpick that could be done on commit or you could pick it off @kim.pepper?

+++ b/core/includes/file.inc
@@ -512,8 +512,8 @@ function file_unmanaged_prepare($source, &$destination = NULL, $replace = FILE_E
+    // @todo Replace \Drupal::messenger()->addError() calls with exceptions instead.

Minor 80 char line limit that needs a wrapping.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +@deprecated
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
StatusFileSize
new 2935779-6.patch8.9 KB
new 2935779-6-interdiff.txt973 bytes

Fixes #5

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed e814d6f and pushed to 8.6.x. Thanks!

  • catch committed e814d6f on 8.6.x 
    Issue #2935254 by kim.pepper: Remove all usages of drupal_get_message...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.