Closed (fixed)
Project:
Drupal core
Version:
8.5.x-dev
Component:
media system
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
7 Jan 2018 at 14:31 UTC
Updated:
12 Feb 2019 at 21:34 UTC
Jump to comment: Most recent, Most recent file




Comments
Comment #2
xjmThe blocker is committed now, so unpostponing!
Comment #3
starshapedCreated patch and tested it by applying the patch to a fresh Drupal install. Screenshots before and after the patch was applied are attached.
Comment #4
phenaproximaRTBC from me. Ideally we would get a +1 from another maintainer, but this looks great. Thanks, @starshaped!
Comment #5
phenaproximaAdding screenshots to the IS.
Comment #6
xjmMinor nitpick: "locally hosted" does not need to be hyphenated. :)
Comment #7
starshapedRemoved those pesky hyphens :)
Comment #8
xjmI double-checked the config exports by diffing an export following installation against the shipped defaults:
Among those things, the
_ccoreanduuidare correct to exclude. The other diffs are actually with the file and image types, rather than audio and video. :) So let's file a followup issue to change the quotes, fix the dependencies, and (I think) add the missing third-party settings.Comment #9
xjmDidn't mean to change status.
Comment #10
phenaproximaFollow-up issue filed: #2934991: Media configuration included with Standard needs to include inherited dependencies.
Comment #12
xjmCommitted and pushed to 8.5.x. Yay! I think this followup means we truly, completely support (local) audio and video. :)
Comment #13
xjmComment #14
xjmComment #16
andrewmacpherson commentedFound this by git blame.
This change should not have been allowed through the accessibility QA gate. It isn't possible for authors to produce accessible audio and video content, i.e. there is no possibility to provide closed captions and/or subtitles for local video media type, or provide a transcript for local audio or local video. So we haven't met the gate requirements for WCAG and ATAG. This issue went through very quickly, without any mention of accessibility, and the accessibility maintainers were unaware of it at the time. Audio and video alternative are among the earliest-numbered level A success criteria for WCAG, which would be found at the start of any WCAG checklist. I'll conclude that no-one attempted to assess this for the accessibility gate.
At Drupalcon Vienna in autumn 2017, I did ask the initiative leads about how authors could provide captions and transcripts, in the Q+A for the media initiative update session. The response was along the lines of "it's not an issue for Drupal core, because we only have file and image media bundles configured", but a couple of months later this was added as quick-win and accessibility was forgotten.
I'm kind of disappointed by this, however let's be pragmatic. These preconfigured local audio and video bundles have been included in the standard profile for a couple of releases now, so it seems a pity to call for a reversion of the commit here. In any case, lots of sites are using these bundles, and it's a popular feature of blog posts, tutorials, and podcasts. Instead let's just get on with filling the feature gap.
A few months ago I filed an minimum-viable plan to address transcripts and closed captions, in #3002770: Provide authors with tools to manage transcripts and captions/subtitles for local video and audio, but it hasn't had a response yet from the media initiative leads. I'll bring it to their attention, and get it a proper place in the media roadmap.