Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Inside modules/media/config/optional/views.view.media.yml
we have:
bundle:
id: bundle
table: media_field_data
field: bundle
relationship: none
group_type: group
admin_label: ''
label: Source
The Source
label is wrong, because that column shows Media Types, not source plugins.
Proposed resolution
Use the correct label.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#8 | media_list.png | 234.86 KB | xjm |
#3 | interdiff-2934649-2-3.txt | 1.2 KB | chr.fritsch |
#3 | 2934649-3.patch | 2.26 KB | chr.fritsch |
#2 | 2934649-2.patch | 926 bytes | marcoscano |
Comments
Comment #2
marcoscanoPostponing this on #2932369: Media Types missing access control handler result in empty column in media overview page, because we need to update the test that is being added there.
Comment #3
chr.fritschUnpostponing because #2932369: Media Types missing access control handler result in empty column in media overview page landed, and updated the test.
Comment #4
chr.fritschComment #5
marcoscanoI believe the machine name is still
source
, so this select wouldn't change its name.Comment #6
marcoscanoStupid me, never mind :)
Looks good, as soon as the bot says it's green.
Comment #8
xjmLooks better to me; also seems like a (small) usability improvement. I tested and the changed label totally makes sense in context:
I also manually tested that the renamed "Type" filter behaves as expected.
Committed and pushed to 8.5.x. Thanks!