The following errors and warnings need to be fixed:

Coding Standard

CommentFileSizeAuthor
#5 improve_coding_standards-2934413-5.patch1.52 KBfjgarlin
#4 coding_standard_warning.png537.19 KBsivaprasadc
#2 improve_coding_standards-2934413-2.patch1.2 KBfjgarlin
coding_standard.png111.66 KBvenkatesh rajan.j

Comments

Venkatesh Rajan.J created an issue. See original summary.

fjgarlin’s picture

fjgarlin commented
Status: Active » Needs review
StatusFileSize
new improve_coding_standards-2934413-2.patch1.2 KB

Hi,

Here is a patch that fixes the coding standards for 8.x-2.x. Hope it helps.
Thanks.

sivaprasadc’s picture

sivaprasadc commented
Assigned: Unassigned » sivaprasadc
sivaprasadc’s picture

sivaprasadc commented
Assigned: sivaprasadc » Unassigned
Status: Needs review » Needs work
StatusFileSize
new coding_standard_warning.png537.19 KB

@fjgarlin

Thanks for the patch. I verified with Codesniffer tool. Still, it is showing 1 more warning PFA.

Thanks

fjgarlin’s picture

fjgarlin commented
Status: Needs work » Needs review
StatusFileSize
new improve_coding_standards-2934413-5.patch1.52 KB

Hi, new patch attached.

  • gnuget committed 6cb6e72 on 8.x-2.x authored by fjgarlin 
    Issue #2934413 by fjgarlin, Sivaprasad C, Venkatesh Rajan.J: Improve...
gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Needs review » Fixed

Fixed.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.