Problem/Motivation

In #2932226: Media Type entities don't validate machine name properly we added a workaround to prevent the bug from #2557299: Any AJAX call disregards machine name verification when AJAX is used and leads to a fatal error from affecting the MediaType form in a very visible way. That workaround should be removed once the underlying bug is resolved.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 2934154-3-remove-workaround.patch2.24 KBkrilo_89
#3 2934154-3-remove-workarond-and-apply-2557299.patch7.73 KBkrilo_89
#3 2934154-3-Test_Only.patch1.28 KBkrilo_89

Comments

marcoscano created an issue. See original summary.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

krilo_89’s picture

krilo_89 commented
Status: Postponed » Needs review
StatusFileSize
new 2934154-3-Test_Only.patch1.28 KB
new 2934154-3-remove-workarond-and-apply-2557299.patch7.73 KB
new 2934154-3-remove-workaround.patch2.24 KB

There's a patch in https://www.drupal.org/project/drupal/issues/2557299#comment-12293838. If this patch is applied and the workaround is removed, this issue will be resolved.

The first patch included is a Test Only which will show that the current code with the workaround doesn't pass. The second patch, will include #2557299: Any AJAX call disregards machine name verification when AJAX is used and leads to a fatal error and remove the workaround from #2932226: Media Type entities don't validate machine name properly. This will pass the test.

The third patch will include the test and remove the workaround. After #2557299: Any AJAX call disregards machine name verification when AJAX is used and leads to a fatal error is committed, this issue can be committed too.

The last submitted patch, 3: 2934154-3-Test_Only.patch, failed testing. View results

The last submitted patch, 3: 2934154-3-remove-workarond-and-apply-2557299.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 3: 2934154-3-remove-workaround.patch, failed testing. View results

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Postponed

I rerolled #2557299: Any AJAX call disregards machine name verification when AJAX is used and leads to a fatal error against 8.6.x, so I'm re-postponing this until that lands.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Postponed » Closed (outdated)

In #2557299-71: Any AJAX call disregards machine name verification when AJAX is used and leads to a fatal error, I have adapted Media's existing tests to prove both the problem and the fix, and thus removed the workaround. Therefore, I'm closing this issue as outdated.