I was going over the Drupal code and noticed that the comments for flood_is_allowed() list the second parameter as $number, but in the code its named $threshold. Not a big deal, but it should probably be fixed.

CommentFileSizeAuthor
#1 293322.diff580 bytesminorOffense
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

minorOffense’s picture

minorOffense CreditAttribution: minorOffense commented
Assigned: Unassigned » minorOffense
FileSize
293322.diff580 bytes

I've created a patch

minorOffense’s picture

minorOffense CreditAttribution: minorOffense commented
Assigned: minorOffense » Unassigned
Status: Active » Needs review
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Version: 6.3 » 6.x-dev
Status: Needs review » Reviewed & tested by the community

This patch applies cleanly to the D6 branch, and appears correct to me.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Title: changecommented parameter name for flood_is_allowed() » Documented parameter name for flood_is_allowed() is incorrect
Category: task » bug
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Version: 6.x-dev » 7.x-dev

Let's apply first to Drupal 7, so we are not introducing regressions.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Patch looks good for D7 as well. Status "reviewed and tested" should stand.

Dries’s picture

Dries CreditAttribution: Dries commented
Version: 7.x-dev » 6.x-dev

Committed to CVS HEAD. Thanks.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Someone should be able to commit the patch from #1 to D6 as well. At least, it applied cleanly a couple of days ago, and I doubt much has changed since then.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed to Drupal 6.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.