CloudFront Purger has 2 dependencies purger and purger_queuer_url but none of them is required in composer.json. Those dependencies should be added so that the module could be installed properly via composer.

CommentFileSizeAuthor
#8 2933152-8-interdiff.txt605 byteskim.pepper
#8 2933152-8.patch1.03 KBkim.pepper
#6 2933152-6.patch445 byteskim.pepper
#2 2933152-composer-update-dependencies-1.patch355 bytessonnykt

Comments

sonnykt created an issue. See original summary.

sonnykt’s picture

sonnykt
Location Melbourne, Australia
commented
StatusFileSize
new 2933152-composer-update-dependencies-1.patch355 bytes
sonnykt’s picture

sonnykt
Location Melbourne, Australia
commented
Status: Active » Needs review
gargsuchi’s picture

gargsuchi commented

Works well. Thanks @sonnykt for the patch.

gargsuchi’s picture

gargsuchi commented
Status: Needs review » Reviewed & tested by the community
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
StatusFileSize
new 2933152-6.patch445 bytes

I think this actually needs to be in 'require' not 'require_dev'.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 2933152-6.patch, failed testing. View results

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Needs work » Needs review
StatusFileSize
new 2933152-8.patch1.03 KB
new 2933152-8-interdiff.txt605 bytes

Found a typo in \Drupal\Tests\cloudfront_purger\Unit\CloudFrontInvalidatorTest::testInvalidateError()

  • kim.pepper committed 57b0fa1 on 8.x-1.x 
    Issue #2933152 by kim.pepper, sonnykt: Add purge/purge_queuer_url...
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Needs review » Fixed

Committed and pushed #6 to 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.