Closed (fixed)
Project:
Blind Carbon Copy
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
20 Dec 2017 at 19:32 UTC
Updated:
5 Nov 2020 at 17:14 UTC
Jump to comment: Most recent
I see that there's no Drupal 8 version of this module, so I created a version of it - https://github.com/maijs/bcc I'd be happy to see a 8.x branch created from this code.
Some comments about Drupal 8 version:
Comments
Comment #2
zoltán balogh commentedThanks, its works well.
Comment #3
devkinetic commentedYour module does work, but putting this into key/value storage vs configuration I think would be a regression. There are a handful of ways to deal with multiple environments like config split or config override.
I used your code @maijs and refactored it.
I export my production config to yml, and then use config override to set the enable flag to false for dev and staging. Before I upload, I need to fork your repo properly on github and put things into git there so credit goes to where credit is due.
Is there a maintainer active?
Comment #4
devkinetic commentedHere is my fork: https://github.com/devkinetic/bcc
Here is a pull request so you can see the comparison: https://github.com/maijs/bcc/pull/1
Comment #5
anybodyThank you @devkinetic,
you've been given access. Please care for the Drupal 8 / 9 branch and ensure it is Drupal 9 compatible and code-clean.
Thank you very much for your contribution!
Comment #6
devkinetic commentedThank you for the access @Anybody,
I've adding coding standards, a schema, and a basic test to get things started. I've also now created a 8.x-3.x branch and 8.x-3.0-beta1 release. I will do my best to review patches and welcome feedback as to what would earmark a stable release for D8.