Closed (fixed)
Project:
Drupal core
Version:
8.5.x-dev
Component:
migration system
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Dec 2017 at 09:46 UTC
Updated:
12 Feb 2018 at 21:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
marcoscanoComment #4
marcoscanoComment #5
chiranjeeb2410 commented@marcoscano,
Tweaked the @return statement doc a bit.
Comment #7
neclimdul#2918837: SqlBase throws fatal error when extended directly already changed the type but the docs might be able to be improved still.
Comment #9
harsha012 commentedComment #10
heddnIt returns an iterator, not an array. See #2918837-22: SqlBase throws fatal error when extended directly.
Perhaps: Returns an iteratable object of data for this source.
Comment #11
harsha012 commentedFixed as per #10
Comment #12
chiranjeeb2410 commented@marcoscano,
Attached interdiff for patches #9 and #11. Doc change suggested by @heddn, in comment #10, seems to be apt. It should in fact return an iterator object.
RTBC good to go!
Comment #13
heddn+1
Comment #15
neclimdulunrelated.
Comment #17
catchCommitted/pushed to 8.6.x and cherry-picked to 8.5.x. Thanks!