There are missing @param entries within the hook_migrate_prepare_row documentation, and there is also no documentation for hook_migrate_MIGRATION_ID_prepare_row().

I suggest that these are both added.

CommentFileSizeAuthor
#4 patch_result_core.png19.62 KBvenkatesh rajan.j
#2 2931368-2.patch1.81 KBopdavies

Comments

opdavies created an issue. See original summary.

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented
Status: Active » Needs review
StatusFileSize
new 2931368-2.patch1.81 KB

This patch adds the missing @param entries, and also the example code for hook_migrate_MIGRATION_ID_prepare_row(). I've used the same code from hook_migrate_prepare_row(), removing only the if statement for $migration->id() as that is not needed, but I'm happy to use different example code if needed.

venkatesh rajan.j’s picture

venkatesh rajan.j commented
Assigned: Unassigned » venkatesh rajan.j
venkatesh rajan.j’s picture

venkatesh rajan.j commented
Assigned: venkatesh rajan.j » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new patch_result_core.png19.62 KB

@opdavies,

Thanks for the patch. Your patch applied cleanly. PFA for the same.

catch’s picture

catch
he/him
Primary language English
commented

@Venkatesh Rajan.J just a note there's no need to upload a screenshot of the patch applying on the CLI, since DrupalCI checks this and reports back if the patch fails on the issue anyway. We don't normally give issue credit for setting an issue to RTBC unless there is a significant review involved, so I'm unassigning credit on this issue but thanks for checking the patch.

  • catch committed 4e5b4b0 on 8.5.x 
    Issue #2931368 by opdavies: Add missing param documentation for...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 4e5b4b0 and pushed to 8.5.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.