Vim can be instructed to set special settings. The line added by this patch tells vim that the file type is php, tab and 'shiftwidth' size is 2 characters and to expand tabs with spaces.
I'd -1 this. I don't use vi to code Drupal, and I'm sure a lot of other people are using something entirely different as well. Allowing this patch would allow the horde to say "oooh, oOh, add this line for MY favorite text editor too!" - when would it stop? Best not to move Drupal into this political territory.
if you're editing the handbook, you might point out to people they could just put the relevant settings in their .vimrc or, if they only want these settings when editing drupal files they can alias say vid to "vi -u ~/.vimrc-drupal" and have two configurations.
But this is a local configuration issue, not a drupal one.
Comments
Comment #1
Cvbge commented(as to not forget) This line can be easili added with
sed -i -e 's!^?>$!// vim: ft=php ts=2 sw=2 et\n?>!'<files>Comment #2
morbus iffI'd -1 this. I don't use vi to code Drupal, and I'm sure a lot of other people are using something entirely different as well. Allowing this patch would allow the horde to say "oooh, oOh, add this line for MY favorite text editor too!" - when would it stop? Best not to move Drupal into this political territory.
Comment #3
Cvbge commentedWell, how many such editors there are? I can name vi* and emacs only...
Comment #4
chx commentedI feel inclined to say "won't fix". There is little use to add this. Add that sed line to handbook and be done.
Comment #5
willmoy commentedif you're editing the handbook, you might point out to people they could just put the relevant settings in their .vimrc or, if they only want these settings when editing drupal files they can alias say vid to "vi -u ~/.vimrc-drupal" and have two configurations.
But this is a local configuration issue, not a drupal one.
Comment #6
chx commentedThat's settled , then.