Getting Recoverable fatal error when webform_id is invalid.
I'm getting this error when I mistyped the webform id value:
The website encountered an unexpected error. Please try again later.<br /><em class="placeholder">Recoverable fatal error</em>: Argument 1 passed to Drupal\webform\WebformSubmissionForm::isOpen() must implement interface Drupal\webform\WebformInterface, null given,
Perhaps the module should provide a validation for a valid webform object before proceeding with using it.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | webform_rest-getting_recoverable_fatal_error_when_webform_id_is_invalid-2930702-2.patch | 1.18 KB | mqanneh |
Comments
Comment #2
mqannehComment #3
mqannehSince we are not concerned about cacheability metadata here, I updated the patch to return ResourceResponse instead of ModifiedResourceResponse.
Comment #4
mqannehComment #5
imclean commented#3 This is intentional. Other actions, such as sending an email, requires cache metadata to be added. I'm not sure what this would be which is why it returns a
ModifiedResourceResponse.See: #2899161: Submitting a Webform which has an email handler results in a 500 error
Comment #6
mqanneh@imclean
ok. so I'll rewrite my patch to use ModifiedResourceResponse but we still need this patch to validate that we have a valid webform id. the module only checks that it's not an empty value for the webform id which is not enough.
what do you think?
check patch #2
Comment #7
mqannehComment #8
imclean commentedLooks good, thank you.
Comment #10
imclean commentedComment #11
mqanneh