Backslash single quote does not make month name translatable in taarikh.fatimid_astronomical.js, maybe this is an issue in Drupal core.

CommentFileSizeAuthor
#4 backslash_translation-2930691-4.patch3.11 KBanas_maw
#2 backslash_translation-2930691-2.patch1.12 KBanas_maw

Comments

Anas_maw created an issue. See original summary.

anas_maw’s picture

anas_maw commented
Status: Active » Needs review
StatusFileSize
new backslash_translation-2930691-2.patch1.12 KB

This patch solve the issue

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs review » Needs work 
+++ b/js/taarikh.fatimid_astronomical.js
@@ -17,8 +17,8 @@
+          monthNames: [Drupal.t('Muharram'), Drupal.t('Safar'), Drupal.t("Rabi' al-awwal"), Drupal.t("Rabi' al-aakhar"),
+            Drupal.t('Jumada al-awwal'), Drupal.t('Jumada al-aakhar'), Drupal.t('Rajab'), Drupal.t("Sha'aban"),

Thanks, can you change all the strings to use double quotes instead of single?

anas_maw’s picture

anas_maw commented
Status: Needs work » Needs review
StatusFileSize
new backslash_translation-2930691-4.patch3.11 KB

Here is an updated patch as requested.
Adding me as author of the commit will be appreciated.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed. Thanks for the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.