@jfmacdonald found this in #2912642-30: Add @internal to automated tests classes

CommentFileSizeAuthor
#5 2929464-5-move_test_files.patch650 bytestedbow
#2 2912642-2.patch1.24 KBtedbow

Comments

tedbow created an issue. See original summary.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 2912642-2.patch1.24 KB

This patch just adds a test failure to both tests to see if they are ignored.

Also going to ping @jfmacdonald about this to see how he found these and if he has found others.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Active » Needs review
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

Ok this is where seems to have happened #2686207-16: Convert simpletest kernel tests in modules A-I to phpunit

If I search for "tests/modules/src" in the commit these files are the ones found.

So hopefully these are the only problem test classes

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
StatusFileSize
new 2929464-5-move_test_files.patch650 bytes

This patch moves the test files to where I think they should be.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue summary: View changes
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 5: 2929464-5-move_test_files.patch, failed testing. View results

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Needs review

The testes passed and both tests can be in seen in the full log passing: https://dispatcher.drupalci.org/job/drupal_patches/40097/consoleFull

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
commented
Status: Needs review » Reviewed & tested by the community

$ find ckeditor -name '*Test.php' -print
ckeditor/tests/modules/src/Kernel/CKEditorPluginManagerTest.php
ckeditor/tests/modules/src/Kernel/CKEditorTest.php
ckeditor/tests/src/Functional/CKEditorAdminTest.php
ckeditor/tests/src/Functional/CKEditorLoadingTest.php
ckeditor/tests/src/Functional/CKEditorStylesComboAdminTest.php
ckeditor/tests/src/Functional/CKEditorToolbarButtonTest.php
ckeditor/tests/src/FunctionalJavascript/AjaxCssTest.php
ckeditor/tests/src/FunctionalJavascript/CKEditorIntegrationTest.php
ckeditor/tests/src/Kernel/Plugin/CKEditorPlugin/InternalTest.php
ckeditor/tests/src/Unit/CKEditorPluginManagerTest.php
ckeditor/tests/src/Unit/Plugin/CKEditorPlugin/LanguageTest.php

Shows two tests in wrong place in filesystem

  1. similarity index 100%
rename from core/modules/ckeditor/tests/modules/src/Kernel/CKEditorPluginManagerTest.php

rename from core/modules/ckeditor/tests/modules/src/Kernel/CKEditorPluginManagerTest.php
rename to core/modules/ckeditor/tests/src/Kernel/CKEditorPluginManagerTest.php

rename to core/modules/ckeditor/tests/src/Kernel/CKEditorPluginManagerTest.php
diff --git a/core/modules/ckeditor/tests/modules/src/Kernel/CKEditorTest.php b/core/modules/ckeditor/tests/src/Kernel/CKEditorTest.php

    Proper move. 

  2. similarity index 100%
rename from core/modules/ckeditor/tests/modules/src/Kernel/CKEditorTest.php

rename from core/modules/ckeditor/tests/modules/src/Kernel/CKEditorTest.php
rename to core/modules/ckeditor/tests/src/Kernel/CKEditorTest.php

rename to core/modules/ckeditor/tests/src/Kernel/CKEditorTest.php
 

    Proper move.

https://dispatcher.drupalci.org/job/drupal_patches/40097/consoleText shows

Drupal\Tests\ckeditor\Kernel\CKEditorPluginManagerTest 2 passes
Drupal\Tests\ckeditor\Kernel\CKEditorTest 7 passes

LGTM.

  • catch committed 0b67173 on 8.5.x 
    Issue #2929464 by tedbow, mpdonadio: Tests under "core/modules/ckeditor/...

catch credited jfmacdonald.

catch’s picture

catch
he/him
Primary language English
commented

  • catch committed 4c82080 on 8.4.x 
    Issue #2929464 by tedbow, mpdonadio: Tests under "core/modules/ckeditor/...
catch’s picture

catch
he/him
Primary language English
commented
Version: 8.5.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.5.x and cherry-picked to 8.4.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.