Closed (fixed)
Project:
Guardian
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
8 Dec 2017 at 08:04 UTC
Updated:
15 Feb 2018 at 17:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
ritzz commentedWorking on it.
Comment #5
tessa bakkerOne issue left to fix, the LICENSE is needed for GitHub:
Comment #6
idebr commentedAttached patch should fix most of the remaining coding standard issues.
Comment #7
tessa bakkerLooks really good!
Some small things:
* drupal_set_message is deprecated with D8.5
* the user storage is only needed within the Manager, replacing entityTypeManager with userStorage make the code cleaner
* r129 $site = $this->configFactory->getEditable('system.site')->get('name'); isn't an editable variable, $this->configFactory->get('system.site')->... is more than enough
Comment #8
tessa bakkerComment #9
idebr commented#7.1 Created a followup issue to replace drupal_set_message(), since there is no stable version of Drupal 8.5.x yet. The issue is available at #2941390: Replace deprecated drupal_set_message() with Messenger service
#7.2 Moved entityTypeManager->getStorage('user') to the construct function based on the pattern in \Drupal\Core\Installer\Form\SiteConfigureForm. Is this what you had in mind?
#7.3 Replaced $this->configFactory->getEditable('system.site') with $this->configFactory->get('system.site')
Comment #11
tessa bakkerThanks for the new patch :)