Around Lines 203, 205, 206 and 207 in printfriendly.module, closing quote syntax is mixing.

See highlights in png attachment

How to Witness Issue:
Open a browser and load a page which is using the module.
Bring up the web developer console and under Console the missing syntax is reported as expected/unexpected

CommentFileSizeAuthor
printfriendly-minor-bug.png22.2 KBresmonde

Comments

resmonde created an issue. See original summary.

bcobin’s picture

bcobin commented

Thanks for this. Also note that the missing quote needs to be added to the beginning of the string as well. Below is the modified module code that eliminates the error. Thanks again!

 // Attach JS custom settings
  $custom_js  = "var pfHeaderImgUrl = '". variable_get('printfriendly_page_custom_header') ."';";
  $custom_js .= "var pfHeaderTagline = '". variable_get('printfriendly_tagline') ."';";
  $custom_js .= "var pfdisableClickToDel  = '". variable_get('printfriendly_click_delete') ."';";
  $custom_js .= "var pfHideImages = '". variable_get('printfriendly_images') ."';";
  $custom_js .= "var pfImageDisplayStyle = '". variable_get('printfriendly_image_style') ."';";
  $custom_js .= "var pfDisablePDF = '". variable_get('printfriendly_pdf') ."';";
  $custom_js .= "var pfDisableEmail = '". variable_get('printfriendly_email') ."';";
  $custom_js .= "var pfDisablePrint = '". variable_get('printfriendly_print') ."';";
  $custom_js .= "var pfCustomCSS = '". variable_get('printfriendly_custom_css') ."';";
  $custom_js .= "var pfPlatform = 'Drupal 7';";

  • Fabsgugu committed 9bffa5b on 7.x-5.x 
    Issue #2929041 by resmonde, bcobin: Missing Closing Quote syntax in...
fabsgugu’s picture

fabsgugu commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.