The provided --exclude option can be useful, but Drush also uses that name :( to exclude modules from loading. And Aegir leverages that feature.

So I opt to rename it to 'exclude-tables'.

The warning I got before changing this:

explode() expects parameter 2 to be string, array given utf8mb4_convert.drush.inc:154                                                                                                                                                                                           [warning]
array_diff(): Argument #2 is not an array utf8mb4_convert.drush.inc:154                                                                                                                                                                                                         [warning]
sort() expects parameter 1 to be array, null given utf8mb4_convert.drush.inc:157                                                                                                                                                                                                [warning]
Invalid argument supplied for foreach() utf8mb4_convert.drush.inc:159
CommentFileSizeAuthor
#3 utf8mb4_convert-rename_exclude_option-2928840-3.patch1.74 KBhargobind
utf8mb4_convert-rename_exclude_option.patch1.54 KBhelmo

Comments

helmo created an issue. See original summary.

jacob.embree’s picture

jacob.embree commented
Status: Needs review » Reviewed & tested by the community

I agree. I got the same errors. helmo's patch fixed them. The renamed option works.

hargobind’s picture

hargobind
he/him
Location Austin, Texas
commented
StatusFileSize
new utf8mb4_convert-rename_exclude_option-2928840-3.patch1.74 KB

One minor change here. The $exclude variable name should be changed to $exclude_tables for consistency.

Aside from that, this patch works great!

  • stefan.r committed 8998548 on 7.x-1.x authored by hargobind 
    Issue #2928840 by helmo, hargobind: Change 'exclude' option to something...
stefan.r’s picture

stefan.r commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.