Problem/Motivation

The SAML login page currently displays the 'maintenance mode' page when the site is in maintenance mode. As a result, users who rely on SAML authentication cannot maintain the site through the UI.

Proposed resolution

Exempt the SAML login page from maintenance mode 'protection'.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

The SAML login page is available when the site is in maintenance mode.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 simplesamlphp_auth-allow_in_maintenance_mode-2928514-2.patch709 bytesidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new simplesamlphp_auth-allow_in_maintenance_mode-2928514-2.patch709 bytes

Attached patch adds the option _maintenance_access: TRUE to the SAML login route, so it is available when the site is in maintenance mode.

dakku’s picture

dakku commented

Thank you Ide, patch looks good to me :)

  • dakku committed 117cbbd on 8.x-3.x authored by idebr 
    Issue #2928514 by idebr: [D8] Allow SAML login when in maintenance mode
dakku’s picture

dakku commented
Status: Needs review » Fixed
idebr’s picture

idebr commented

Thank you for fixing this issue so quickly and taking the time to maintain this project, dakku.

While I have your attention, can you take a look at the issue regarding the automated tests on the 8.x-3.x branch at #2898517: Fix Tests for 8.x-3.x-dev branch? These tests would guarantee the module's stability moving forward.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.