Follow-up: remove unnecessary returns in ajax.js

We reverted that before the commit in order to have a patch which was easier to understand. Of course your code is a bit better, but I'm wondering whether we could go through more code and apply these kind of optimizations.

Applies cleanly, good optimization refactorization.

Re-queued the test, it failed on composer for some reason?

It'd be great to get answer to @dawehner's

Of course your code is a bit better, but I'm wondering whether we could go through more code and apply these kind of optimizations

Especially since the issue title makes someone expect a much larger patch.

If we want to focus on just this one - fine but the issue title needs fixing.

I guess we could do the same here:

        response.stylesheets.forEach((url) => {
          editor.document.appendStyleSheet(url);
        });

And maybe here

      // List of fields IDs on which to bind the event listener.
      // Create an array of IDs to use with jQuery.
      Object.keys(drupalSettings.copyFieldValue || {}).forEach((element) => {
        ids.push(element);
      });

Do we know whether there is an eslint rule covering this?

need reroll :)

Hi,

Creating a patch for this issue.

Please review the patch.

Thanks.

Fixed CS issues.

applied patch remove-return.patch and working as expected.

Patch not working in drupal-9.3.x-dev
Needs to re-roll
giving error while going to apply patch #18

At the moment patches are applied to the 10.x branch first so a patch or MR for that version is needed.

I'm ok with the change itself, just need the right version for the 10.x branch :)

I rerolled the patch #18 for the 10.0.x branch.

Needs a reroll for 10.1 now that es6 files are no longer used

reroll against 10.1 address #25

Went through all core calls of .forEach() and .map() in JS files. Found one possible update in olivero but that's it. The rest would require more involved refactoring.

Given that, RTBC it's small and painless to keep that scoped to ajax.js.

Committed and pushed 8a3da3d43f to 10.1.x and 5ee487c087 to 10.0.x. Thanks!