Wrong language in multilingual summary

I think the problem lies in the getNestedSummary() where the referenced entity is fetched but there is nothing language specific.
In my case I do see paragraph values in correct language, but if that paragraph has nested paragraphs, they appear in the summary in the original (source) language.

Here is a patch which seems to fix it.

While testing this I realized that this might work better when there are multiple translation of the node. I will work on the tests tomorrow.
@mErilainen thanks for your patch! :)

To me it seems that the last patch is trying to fetch the nested paragraph in the parent paragraph's source language, which would not be the translation being edited. And it doesn't work either, see the attached screenshot.

Ohhh I see, then I found a different problem. When we have more than one translation for the node. And we select the source language that we want to translate, when we switch the language, the summary always displays the original language.

Will open an issue for that.

I could replicate what you mean, think your first patch made sense then, working on tests now. :)

So should I add my first patch back here to get it tested?

There we go with tests. :) This should avoid regressions later. :)

This is the other bug I found #2997565: Summary does not follow the source language.

+++ b/src/Entity/Paragraph.php
@@ -658,6 +658,11 @@ class Paragraph extends ContentEntityBase implements ParagraphInterface {
+          if ($entity->hasTranslation($this->activeLangcode)) {
+            // Check if nested paragraph has a translation for the parent
+            // paragraph's language and use that if there is.
+            $entity = $entity->getTranslation($this->activeLangcode);
+          }

Lets also do that for the referenced entities and their label.

Thought about using \Drupal\Core\Entity\EntityRepositoryInterface::getTranslationFromContext(), but I don't think we care about the fallback here. It would save the hasTranslation check though.

True, referenced entities had the same problem. This should fix it. :)

+++ b/src/Entity/Paragraph.php
@@ -465,7 +465,10 @@ class Paragraph extends ContentEntityBase implements ParagraphInterface {
+          $entity = $this->get($field_name)->entity;
+          // Switch to the entity translation in the current context if exists.
+          $entity = $this->entityManager()->getTranslationFromContext($entity, $this->activeLangcode);
+          $summary[] = $entity->label();

entityManager() is deprecated, we shouldn't add new usages of that. The problem is that this method moved to a different service, so you can't use entityTypeManager() but have to call out to \Drupal::service()

I am starting to work on this on #drupaleurope

Changed code to use Drupal::service() instead of entityManager()

+++ b/src/Entity/Paragraph.php
@@ -658,6 +661,8 @@ class Paragraph extends ContentEntityBase implements ParagraphInterface {
+          $entity = $this->entityManager()->getTranslationFromContext($entity, $this->activeLangcode);

Let's also change here. :)

Changed the other entityManager() occurence as well.

That's still the wrong service though, you still use the deprecated entity manager.

The service you need to use is entity.repository.

Hi @Berdir

You are totally right. Missed that point and fixed it now.

Thanks.