There are a number of coding standards violations that need to be addressed.

CommentFileSizeAuthor
#4 Remaining file 2.png29.24 KBriddhi.addweb
#4 Remaining file.png89.02 KBriddhi.addweb
#2 2927189.patch2.05 KBioana apetri

Comments

Shamrockonov created an issue. See original summary.

ioana apetri’s picture

ioana apetri commented
Status: Active » Needs review
StatusFileSize
new 2927189.patch2.05 KB

Hello, I added my patch. Please review,thanks

shamrockonov’s picture

shamrockonov
Location Wales 🏴󠁧󠁢󠁷󠁬󠁳󠁿
commented

thanks @yo30. Will review shortly

riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Needs work
StatusFileSize
new Remaining file.png89.02 KB
new Remaining file 2.png29.24 KB

@yo30, Thanks for solving the standard errors , but as i checked it with pareview.sh some errors are still missed to solved. Can you please do the needful, I attached screenshots for that also.

  • Shamrockonov committed c3be800 on 8.x-1.x authored by yo30 
    Issue #2927189 by yo30, Jigar.addweb: Fix coding standards violations
shamrockonov’s picture

shamrockonov
Location Wales 🏴󠁧󠁢󠁷󠁬󠁳󠁿
commented
Status: Needs work » Fixed

Thank you, both, for your input.
I've added the patch, added any remaining changes and committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.