The photo_access submodule does not implement hook_help

Add hook_help as per https://www.drupal.org/docs/develop/documenting-your-project/module-docu...

Patch to follow, thanks!

CommentFileSizeAuthor
#7 Screen Shot 2017-12-09 at 8.03.20 AM.png72.32 KBvolkswagenchick
#7 Screen Shot 2017-12-09 at 8.03.10 AM.png37.98 KBvolkswagenchick
#6 interdiff-2927162-2-6.txt3.41 KBshashwat purav
#6 2927162-6.patch3.03 KBshashwat purav
#2 photos-d8-photo_access-add-hook-help-2927162-2.patch1.68 KBvolkswagenchick

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
StatusFileSize
new photos-d8-photo_access-add-hook-help-2927162-2.patch1.68 KB

Hello!

I have uploaded a patch that implements hook_help for the photo_access submodule, thanks!

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented

Patch applies, but the submodule is not added to the help page. Keeping status as needs work.

shashwat purav’s picture

shashwat purav commented
Issue tags: +DrupalMumbaiCodeSprint

Assigning this issue for Drupal Mumbai Code Sprint Dec 2017.

shashwat purav’s picture

shashwat purav commented
Assigned: volkswagenchick » shashwat purav
shashwat purav’s picture

shashwat purav commented
Assigned: shashwat purav » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2927162-6.patch3.03 KB
new interdiff-2927162-2-6.txt3.41 KB

Added patch to add hook_help(). Also adding inter-diff file for the reference.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2017-12-09 at 8.03.10 AM.png37.98 KB
new Screen Shot 2017-12-09 at 8.03.20 AM.png72.32 KB

Thanks for your help with this issue. I tested patch #6 using simplytest.me and patch applies clean.

Enable the modules and hook help is now available for photo-access.

Screenshots provided. Marking as RTBC

nathaniel’s picture

nathaniel commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch! Quick note:

In D8 the coding standards are to use the short array syntax now [] instead of array().
https://www.drupal.org/docs/develop/standards/coding-standards#array

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.