While evaluating this module, I discovered that the photo_access submodule does not have a readme.

According to Drupal standards, modules should include a useful README.file.
https://www.drupal.org/docs/develop/documenting-your-project/module-docu....
Patch to follow, thanks!

CommentFileSizeAuthor
#2 photos-d8-photo_access-add-readme-2927154-2.patch3.02 KBvolkswagenchick

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
StatusFileSize
new photos-d8-photo_access-add-readme-2927154-2.patch3.02 KB

I uploaded a patch for the photo_access submodule.

Thanks again for this very useful module!

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs work » Needs review

Ooops - forgot to change status.

Marked needs review.

porkloin’s picture

porkloin commented

Patch applied cleanly using simplytest.me and tested configs. Grammar and formatting also look correct!

porkloin’s picture

porkloin commented
Status: Needs review » Reviewed & tested by the community

nathaniel’s picture

nathaniel commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.