Thanks for this very useful module. While evaluating the D8 branch, I found the readme lacked some basic configurations and did not conform to d.o documentation guidelines.

https://www.drupal.org/docs/develop/documenting-your-project/module-docu...
Patch to follow!

CommentFileSizeAuthor
#2 photos-d8-fix-readme-2926947-2.patch7.08 KBvolkswagenchick

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Assigned: volkswagenchick » Unassigned
Status: Needs work » Needs review
StatusFileSize
new photos-d8-fix-readme-2926947-2.patch7.08 KB

I uploaded a patch that revises the README for readability and documentation standards. Thanks!

dani3lr0se’s picture

dani3lr0se commented
Status: Needs review » Reviewed & tested by the community

I tested via simplytest.me and it spins up fine. The patch applies nicely. The grammar and styling looks good as well. I didn't notice any typos or anything. This is also easy to follow and makes sense. Thank you for the patch.

nathaniel’s picture

nathaniel commented
Status: Reviewed & tested by the community » Fixed

Awesome, thanks for the patch and review. I'll open followup issues for hook_help and hook_install message.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented

Thanks!
I am encouraging team mates to help out on Drupal.org, could you go back and give Daniel_Rose a credit for his RTBC?? The box next to his name just gets ticked and he gets a credit! I see it as a way of incentive to help get involved it the community! It takes a village.

Cheers!

AmyJune - volkswagenchick

nathaniel’s picture

nathaniel commented

Yep, thanks for the tip. I wasn't sure about that.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.