Comments

ShaunDychko created an issue. See original summary.

shaundychko’s picture

Issue summary: View changes
shaundychko’s picture

Status: Active » Needs review
StatusFileSize
new3.92 KB
shaundychko’s picture

Assigned: Unassigned » shaundychko
Status: Needs review » Needs work

Needs some code sniffer cleanup.

shaundychko’s picture

Status: Needs work » Needs review
StatusFileSize
new4.54 KB
shaundychko’s picture

StatusFileSize
new3.98 KB

I didn't mean to code-cleanup an unrelated file.

shaundychko’s picture

Assigned: shaundychko » Unassigned
christophweber’s picture

Status: Needs review » Reviewed & tested by the community

Works as advertised. Thanks ShaunDyko!

karens’s picture

A couple notes:

- isAccessibleForFree is a valid item on things other than web pages, it can also go on Events and Places, according to Schema.org. So it should be added as a base tag and then included on those.
- The second element is 'hasPart', which Google is using to find the part of the page that is paywalled. But that element can also be used for other things. Google's method is applicable to all the written content, so could go on WebPage, Article, or any kind of CreativeWork. So again I think this needs to be a base tag that is extended in those places. This one is trickier because the current need is only for paywall info, but it could apply to other things in the future.

I have to think about the best way to set this up without closing off things that might be required in the future.

  • KarenS committed 2b682e2 on 8.x-1.x authored by ShaunDychko
    Issue #2926877 by ShaunDychko, ChristophWeber, KarenS: Indicate...
karens’s picture

Moved these classes to be base classes and added them to Article and Event as well. I remove the alter() code that removes an element if the classes are empty. That is different than the way anything else works so it will be a maintenance and UX problem. I just altered the descriptions to make it clear that if you fill out one you need to fill out the other. Since classes have to be hard-coded (no token is going to do that) and isAccessibleForFree also will have to be hard-coded, no reason to have something "magic" updating things behind the scenes. Just fill out both.

Thanks!

karens’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.