Missing dependencies for ContextReaction\Blocks

Replace the line 388 with this

$entity = reset($this->entityTypeManager()->getStorage($entity_type)->loadByProperties(['uuid' => $uuid]));

Just one depency injection...
I tested this.
Also where can I see if depencies are getting exported?
I went debugging and saw that something is added to dependency array.

I tested this patch and its working.
I added block Page title and it was not exported to the config because this is working just for block_content blocks.
Should depencies for blocks get exported as well?

Yes I think that will be much better :)

Nice work guys.

But I think the dependency calculation should live inside each Condition/Reaction plugin. The context calculateDependencies() should only collect the condition/reaction plugins instances dependencies and merge them to the parent::calculateDependecies(), if any ConfigEntityBase::calculateDependencies() already process each condition/reaction instance calculateDependencies(), it just a matter of adding some logic, as at the moment it just return an empty array .

Attached patch add dependencies for block using a PluginDependencyTrait(). This dependencies are only for the Blocks ContextReaction plugin.
It adds all required block dependencies: configs, content and modules.

This issue summary needs to be update, and maybe follow up must be create to add dependency for example on the selected theme for the Theme ContextReaction plugin.

Also settings 8.x-1.x as target branch due #2933080: 8.x-4.x branch is attached to 7.x code.

Updating the issue summary.

Updating the issue title to reflect what the work on this issue refers to (ContextReaction\Blocks dependencies).

Can we have this patch in please? We need it on every project we work on, to make sure blocks created on a local environment will get created on other environments using config management

Please commit, so we don't have to use patches for our deployments anymore.

Hi quys. I think that something went wrong and this issue still exists. I can see that calculateDependency method is never called so we have no dependencies for our blocks. I tested patch from #2 and it works but need reroll.

I'll provide a patch for it.

I have created a reroll patch for 8.x-4.x, needs review.

I created a new patch to add the dependency.
The problem of patch #2 is that it calculates the block dependency in the context entity and it is not right IMHO.
In the patch that I attached, it adds dependency for conditions and reactions.

Please review it.

Small documentation fix.

Patch #21 adds dependency successfully. Moving to RTBC and updating branch.

Fixed!
Thanks.