When the dependent Datetime field is configured to use the datetime_type: date (i.e. not datetime_type: datetime),
the module's current code fails with a IcalTimezoneInvalidTimestampException.
As a result, after saving the respective entity, there is no generated ics file.
Make the code more robust by covering the case where the dependent Datetime field may be configured to use dates without times.
Write a test covering this case.
Update the code to cover the new test case.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | ics_field-fix-date-without-time-2924791-2.patch | 924 bytes | LeGront |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
LeGront commentedHere the patch for date without time.
Comment #4
iyyappan.govindGood work!
Comment #5
stefanos.petrakisI am going to pick this up.
First I will try to figure out what the OP was going for, from the provided patch #2.
And update the issue's Description accordinglay
Comment #6
stefanos.petrakisComment #7
stefanos.petrakisComment #9
stefanos.petrakisSo, this one is now complete, a new test case for capturing the reported problem, as well more or less applying the solution from #2.
Reviews are very welcome.
Comment #11
stefanos.petrakisI am going to merge this, it is a small but quite annoying piece of missing functionality.