Thanks for a great module!
Problem/motivation:
When selecting LANGUAGE -> Rendering language: Content language of view row view breaks and throws error.
The reason seems to be that in file src/Plugin/views/Entity/Render/ConfigurableLanguageRenderer.php
ConfigurableLanguageRenderer was implemented as an abstract class, which couldn't instantiate.
We've tried to create a temporary patch which makes the class non-abstract and implements the query and render methods (same as in TranslationLanguageRenderer.php).
Proposed solution:
Make the ConfigurableLanguageRenderer non-abstract.
There also seems to be a need to solve this for the other render classes.
Please let us know if we can help further to move this issue forward for a stable release, so that there won't be a need for a patch.
Kind regards
Leander
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | view_parity_row-content-language-broken-2924342-1.patch | 1.16 KB | leanderl |
Comments
Comment #2
leanderl commentedComment #3
polHi,
Your patch and contribution are more than welcome.
As I don't use this module for now, I'll be glad to commit patches for sure.
Is this patch the final version ?
Thanks.
Comment #4
leanderl commentedHello Pol, yes the patch works for us in our project.
But I must admit I don't have the full picture of how the module works and haven't analyzed it in depth.
I'm a little puzzled as to why those classes (src/Plugin/views/Entity/Render/...) are abstract to begin with.
Comment #5
johnpicozziThis patch resolved the error for me RTBC +1
Comment #7
polOk, I do trust you guys :-)