Problem
On line 41, where taxonomy_term_data (ttd) is joined with taxonomy_term_field_data (ttfd), there is a join with a criteria of ttd.vid = ttfd.vid. This is incorrect and should probably be tid.
$query->innerJoin('taxonomy_term_data', 't', 'tfd.vid = t.vid');
This (among other things) will cause the count method to return incorrect results, which in turn will make dependencies in migrations impossible, since taxonomy term migrations will always register as incomplete.
I will create a patch and submit.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | migrate_drupal_d8-fix-inner-join-2923387-2.patch | 639 bytes | jcalais |
Comments
Comment #2
jcalais commentedComment #3
jcalais commentedAdded Patch.
Comment #4
heddnA couple notes, all this code will probably get deprecated shortly once #2935951: Copy migrate source plugin from migrate_drupal_d8 into migrate_drupal lands. However, if you want to provide a test case with this fix, I'll be happy to commit it.
Comment #5
heddnI think this is long out of date. If that isn't the case, feel free to re-open and provide an updated direction.